I've put together a preliminary itinerary and would love some opinions on how "doable" it is.

Day 1 - Flying to Barcelona - sleep Barcelona

Day 2 - Barcelona - sleep Barcelona

Day 3 - Barcelona - sleep Barcelona - possible day trip to Figueres (Dali Museum)taking the Catlunya Express

Day 4 - Barcelona - sleep Barcelona

Day 5 - Fly Vueling to Seville in the morning - sleep Seville

Day 6 - Seville - sleep Seville

Day 7 - Seville (Bus to Tarifa in the evening) - sleep Tarifa

Day 8 - Tarifa (Day trip to Morocco) - sleep Tarifa

Day 9 - Travel to Gibraltar in the morning and then on to Granada - sleep Granada

Day 10 - Granada - sleep Granada - visit Alhambra

Day 11 - Travel to Toledo in the morning - sleep Toledo

Day 12 - Travel to Madrid in the morning - sleep Madrid

Day 13 - Madrid - sleep madrid

Day 14 - Madrid (possible day trip to Segovia)- sleep Madrid

Day 15 - Madrid - sleep Madrid

Day 16 - Madrid - sleep Madrid

Day 17 - Fly Home

Should I allow more time in Tarifa and skip Gibraltar?

Should I skip Toledo and spend another night in Granada or maybe add that extra day to the beiginning of my trip in Barcelona or Seville?

Since I have friends in Madrid I've allowed more time for it at the end of my trip.

Thanks for any and all advice/suggestions!

I would not make the time investment to go to Gibraltar. Best views of The Rock are from the Spanish Shore anyway!

I have not been to Tarifa/Morocco so I am not able to recommend anything there. Personally, I would put that time to good use in the White Villages.

I would add a day in Granada (much more than the Alhambra) and another full day in the Sevilla.

I would skip Morocco (it's like going to Tijuana and saying you've been to Mexico) and Gibralter and concentrate on Spain. Spend those days on the coast near Cadiz or in Nerja. It would be a very long day travelling to Gibralter then travelling to Granada. And you have a lot of days in Madrid. I would spend another day in Sevilla, drive through the Pueblos Blancos to the coast for a couple of days and daytrip to Granada or go on from Granada to Madrid/Toledo. You don't need to sleep in Granada.

We took a private tour of Gibralter and had fun, but it wasn't worth all the time it took. So, I would skip it and spend the extra day in Granada. It is beautiful and more to do.

I am a nut about architecture and cathedrals, so this is biased. . . Don't skip Toledo. It is magical at night and the cathedral is magnificent. The transparente is so beautiful, it just takes your breath away. It is also a wonderful contrast to the Sagrada Familia you will have seen in Barcelona.

Don't skip Toledo... one of my favorite places in Spain. I agree with the previous poster that you should skip Gibralter and Morocco--focus on Spain. You've got plenty of time in Barcelona-- if it were me, I'd add a night to Seville, and maybe spend 2 nights in Toledo...

Sounds like I should skip Gibraltar and possibly spend that extra day in Toledo.

I'm not sure I want to skip Morocco but if I did then should I skip Tarifa altogether? And add that day to Seville or Granada?

Thanks for all the suggestions it's really helpful!

Unless you're a huge Dali fan I'd say skip Figueres. A better daytrip from Barcelona would be Montserrat or Girona.

I didn't see what time of year you're travelling, but assuming it's somewhere between late Spring and early Fall, I'd be reluctant to suggest you give up the South Coast of Spain. We had a magical couple of days at the Hotel Hurricane outside of Tarifa. The rooms are plain, but the views, and what they do with meat (grilled hardly does it justice) will stick with me forever (hope you're not a vegan).

Toledo -- by the time we got there (after 3 weeks which included Madrid, Granada and Seville) we felt somewhat like we were treading the same ground. Spectacular cathedral, great suckling pig, but we'd already seen a lot of Jesus and Mary, and I was getting full. With hindsight, I would have given it up for a bit more time in the White Hill towns. We had an amazing 3 days in and around Ronda.