how long in Granada?
 

visiting Barcelona - 7 days ( jatlag)
Madrid - 7 days ( Toledo)
Granada?
any other suggestions
we are not driving.

1 day, that's it IMO even though it has one of europe's most fascinating and amazing sights and a neat ancient area right under it.

I don't know Barcelona, but 7 days may be too long. And although - unlike many posters here - I like Madrid very much, I wonder whether 7 days are necessary. In addition to Toledo, you might consider day trips to El Escorial/Avila and/or Segovia.

In Andalucia, in addition to Granada (I'd suggest at least 2, preferably 3 days; reserve for the Alhambra - it has a Web site - and if you can, go there during the day and also in the evening, when it is quite magical), Seville (also 2 or 3 days), Cordoba (2 days should do it), Ronda (i overnight).

I did all of the above by train; there are high-speed trains on many of the routes.

From Madrid don't neglect the short day trip to Aranjuez, the 'Spanish Versailles' - easy suburban train trip.

thanks !